Mercurial > irccd

comparison tests/src/libirccd/command-server-nick/main.cpp @ 737:190b16cfa848

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Tests: improve command tests readability
author David Demelier <markand@malikania.fr>
date Tue, 24 Jul 2018 23:01:00 +0200
parents 64839725f346
children 8876412ba633
comparison
equal deleted inserted replaced
736:49b7c7660a00 737:190b16cfa848
43 43
44 BOOST_FIXTURE_TEST_SUITE(server_nick_test_suite, server_nick_test) 44 BOOST_FIXTURE_TEST_SUITE(server_nick_test_suite, server_nick_test)
45 45
46 BOOST_AUTO_TEST_CASE(basic) 46 BOOST_AUTO_TEST_CASE(basic)
47 { 47 {
48 const auto result = request({ 48 const auto [json, code] = request({
49 { "command", "server-nick" }, 49 { "command", "server-nick" },
50 { "server", "test" }, 50 { "server", "test" },
51 { "nickname", "chris" } 51 { "nickname", "chris" }
52 }); 52 });
53 53
54 BOOST_TEST(result.first.is_object()); 54 BOOST_TEST(!code);
55 BOOST_TEST(json.is_object());
55 BOOST_TEST(server_->get_nickname() == "chris"); 56 BOOST_TEST(server_->get_nickname() == "chris");
56 } 57 }
57 58
58 BOOST_AUTO_TEST_SUITE(errors) 59 BOOST_AUTO_TEST_SUITE(errors)
59 60
60 BOOST_AUTO_TEST_CASE(invalid_identifier_1) 61 BOOST_AUTO_TEST_CASE(invalid_identifier_1)
61 { 62 {
62 const auto result = request({ 63 const auto [json, code] = request({
63 { "command", "server-nick" }, 64 { "command", "server-nick" },
64 { "server", 123456 }, 65 { "server", 123456 },
65 { "nickname", "chris" } 66 { "nickname", "chris" }
66 }); 67 });
67 68
68 BOOST_TEST(result.second == server_error::invalid_identifier); 69 BOOST_TEST(code == server_error::invalid_identifier);
69 BOOST_TEST(result.first["error"].template get<int>() == server_error::invalid_identifier); 70 BOOST_TEST(json["error"].get<int>() == server_error::invalid_identifier);
70 BOOST_TEST(result.first["errorCategory"].template get<std::string>() == "server"); 71 BOOST_TEST(json["errorCategory"].get<std::string>() == "server");
71 } 72 }
72 73
73 BOOST_AUTO_TEST_CASE(invalid_identifier_2) 74 BOOST_AUTO_TEST_CASE(invalid_identifier_2)
74 { 75 {
75 const auto result = request({ 76 const auto [json, code] = request({
76 { "command", "server-nick" }, 77 { "command", "server-nick" },
77 { "server", "" }, 78 { "server", "" },
78 { "nickname", "chris" } 79 { "nickname", "chris" }
79 }); 80 });
80 81
81 BOOST_TEST(result.second == server_error::invalid_identifier); 82 BOOST_TEST(code == server_error::invalid_identifier);
82 BOOST_TEST(result.first["error"].template get<int>() == server_error::invalid_identifier); 83 BOOST_TEST(json["error"].get<int>() == server_error::invalid_identifier);
83 BOOST_TEST(result.first["errorCategory"].template get<std::string>() == "server"); 84 BOOST_TEST(json["errorCategory"].get<std::string>() == "server");
84 } 85 }
85 86
86 BOOST_AUTO_TEST_CASE(invalid_nickname_1) 87 BOOST_AUTO_TEST_CASE(invalid_nickname_1)
87 { 88 {
88 const auto result = request({ 89 const auto [json, code] = request({
89 { "command", "server-nick" }, 90 { "command", "server-nick" },
90 { "server", "test" }, 91 { "server", "test" },
91 { "nickname", "" } 92 { "nickname", "" }
92 }); 93 });
93 94
94 BOOST_TEST(result.second == server_error::invalid_nickname); 95 BOOST_TEST(code == server_error::invalid_nickname);
95 BOOST_TEST(result.first["error"].template get<int>() == server_error::invalid_nickname); 96 BOOST_TEST(json["error"].get<int>() == server_error::invalid_nickname);
96 BOOST_TEST(result.first["errorCategory"].template get<std::string>() == "server"); 97 BOOST_TEST(json["errorCategory"].get<std::string>() == "server");
97 } 98 }
98 99
99 BOOST_AUTO_TEST_CASE(invalid_nickname_2) 100 BOOST_AUTO_TEST_CASE(invalid_nickname_2)
100 { 101 {
101 const auto result = request({ 102 const auto [json, code] = request({
102 { "command", "server-nick" }, 103 { "command", "server-nick" },
103 { "server", "test" }, 104 { "server", "test" },
104 { "nickname", 123456 } 105 { "nickname", 123456 }
105 }); 106 });
106 107
107 BOOST_TEST(result.second == server_error::invalid_nickname); 108 BOOST_TEST(code == server_error::invalid_nickname);
108 BOOST_TEST(result.first["error"].template get<int>() == server_error::invalid_nickname); 109 BOOST_TEST(json["error"].get<int>() == server_error::invalid_nickname);
109 BOOST_TEST(result.first["errorCategory"].template get<std::string>() == "server"); 110 BOOST_TEST(json["errorCategory"].get<std::string>() == "server");
110 } 111 }
111 BOOST_AUTO_TEST_CASE(not_found) 112 BOOST_AUTO_TEST_CASE(not_found)
112 { 113 {
113 const auto result = request({ 114 const auto [json, code] = request({
114 { "command", "server-nick" }, 115 { "command", "server-nick" },
115 { "server", "unknown" }, 116 { "server", "unknown" },
116 { "nickname", "chris" } 117 { "nickname", "chris" }
117 }); 118 });
118 119
119 BOOST_TEST(result.second == server_error::not_found); 120 BOOST_TEST(code == server_error::not_found);
120 BOOST_TEST(result.first["error"].template get<int>() == server_error::not_found); 121 BOOST_TEST(json["error"].get<int>() == server_error::not_found);
121 BOOST_TEST(result.first["errorCategory"].template get<std::string>() == "server"); 122 BOOST_TEST(json["errorCategory"].get<std::string>() == "server");
122 } 123 }
123 124
124 BOOST_AUTO_TEST_SUITE_END() 125 BOOST_AUTO_TEST_SUITE_END()
125 126
126 BOOST_AUTO_TEST_SUITE_END() 127 BOOST_AUTO_TEST_SUITE_END()