changeset 539:63f504283797

Irccd: various cleanup in transports
author David Demelier <markand@malikania.fr>
date Mon, 20 Nov 2017 19:20:21 +0100
parents 5c92ebd4423c
children d0e874fe2ef7
files libirccd/irccd/transport_client.cpp libirccd/irccd/transport_server.cpp
diffstat 2 files changed, 0 insertions(+), 51 deletions(-) [+]
line wrap: on
line diff
--- a/libirccd/irccd/transport_client.cpp	Mon Nov 20 19:16:43 2017 +0100
+++ b/libirccd/irccd/transport_client.cpp	Mon Nov 20 19:20:21 2017 +0100
@@ -23,10 +23,6 @@
 
 namespace irccd {
 
-/*
- * transport_client::close
- * ------------------------------------------------------------------
- */
 void transport_client::close()
 {
     state_ = state_t::closing;
@@ -34,10 +30,6 @@
     parent_.clients().erase(shared_from_this());
 }
 
-/*
- * transport_client::flush
- * ------------------------------------------------------------------
- */
 void transport_client::flush()
 {
     if (output_.empty())
@@ -59,10 +51,6 @@
     });
 }
 
-/*
- * transport_client::recv
- * ------------------------------------------------------------------
- */
 void transport_client::recv(recv_t handler)
 {
     assert(handler);
@@ -97,10 +85,6 @@
     });
 }
 
-/*
- * transport_client::send
- * ------------------------------------------------------------------
- */
 void transport_client::send(const nlohmann::json& data, send_t handler)
 {
     assert(data.is_object());
@@ -116,10 +100,6 @@
         flush();
 }
 
-/*
- * transport_client::error
- * ------------------------------------------------------------------
- */
 void transport_client::error(const nlohmann::json& data, send_t handler)
 {
     send(std::move(data), std::move(handler));
--- a/libirccd/irccd/transport_server.cpp	Mon Nov 20 19:16:43 2017 +0100
+++ b/libirccd/irccd/transport_server.cpp	Mon Nov 20 19:20:21 2017 +0100
@@ -24,10 +24,6 @@
 
 namespace irccd {
 
-/*
- * transport_server::do_auth_check
- * ------------------------------------------------------------------
- */
 bool transport_server::do_auth_check(nlohmann::json message, accept_t handler)
 {
     assert(handler);
@@ -48,10 +44,6 @@
     return true;
 }
 
-/*
- * transport_server::do_auth
- * ------------------------------------------------------------------
- */
 void transport_server::do_auth(std::shared_ptr<transport_client> client, accept_t handler)
 {
     assert(client);
@@ -68,16 +60,11 @@
     });
 }
 
-/*
- * transport_server::do_greetings
- * ------------------------------------------------------------------
- */
 void transport_server::do_greetings(std::shared_ptr<transport_client> client, accept_t handler)
 {
     assert(client);
     assert(handler);
 
-    // TODO: update this in irccd.
     auto greetings = nlohmann::json({
         { "program",    "irccd"             },
         { "major",      IRCCD_VERSION_MAJOR },
@@ -103,10 +90,6 @@
     });
 }
 
-/*
- * transport_server::accept
- * ------------------------------------------------------------------
- */
 void transport_server::accept(accept_t handler)
 {
     assert(handler);
@@ -119,12 +102,6 @@
     });
 }
 
-/*
- * tls_transport_server::do_handshake
- * ------------------------------------------------------------------
- *
- * Perform asynchronous SSL handshake.
- */
 void tls_transport_server::do_handshake(std::shared_ptr<tls_transport_client> client, accept_t handler)
 {
     client->socket().async_handshake(boost::asio::ssl::stream_base::server, [client, handler] (auto code) {
@@ -135,20 +112,12 @@
     });
 }
 
-/*
- * tls_transport_server::tls_transport_server
- * ------------------------------------------------------------------
- */
 tls_transport_server::tls_transport_server(acceptor_t acceptor, context_t context)
     : tcp_transport_server(std::move(acceptor))
     , context_(std::move(context))
 {
 }
 
-/*
- * tls_transport_server::do_accept
- * ------------------------------------------------------------------
- */
 void tls_transport_server::do_accept(accept_t handler)
 {
     auto client = std::make_shared<tls_transport_client>(*this, acceptor_.get_io_service(), context_);